-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[genio] Correct dnssd api usage #23848
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23848: Size comparison from 818984e to cf1b628 Increases (3 builds for esp32, psoc6, telink)
Decreases (13 builds for bl602, bl702, efr32, k32w, nrfconnect, psoc6, telink)
Full report (46 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23848: Size comparison from 7431dc2 to c088090 Increases (6 builds for bl602, bl702, esp32, nrfconnect, psoc6, telink)
Decreases (7 builds for cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Dec 1, 2022
@j8xixo12 - needs restyle fixes. |
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple and
jelderton
December 2, 2022 06:15
pullapprove
bot
requested review from
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
msandstedt,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
woody-apple and
xylophone21
December 2, 2022 06:15
bzbarsky-apple
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly rubber-stamping.
PR #23848: Size comparison from 9c0ca13 to 9b8e61f Increases (10 builds for bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Decreases (5 builds for cc13x2_26x2, esp32, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23847
This PR contains following changes: